I always really liked the sights used on guns like the M1917/P14 and Type 99 Arisaka, which are both peep sights but more importantly have both a battle setting, and flip up sights for more precise, longer range shooting. They were easy to use, durable, and pretty accurate too. If I was in the 30s or 40s designing a battle rifle a sight setup like that would be my choice. Similarly I always felt the flip sights on the M1
Carbine were much more practical for the gun's intended use than the sometimes finicky adjustable sights that came later.
Another clever thing on the Type 99 Arisaka are the tang extensions on the rear of the receiver and trigger guard assembly, which I guess were trying to prevent cracking or other damage in that area you sometimes see on other guns. Along with that, I think it was a smart use of resources to make the stocks two pieces.
When looking at safeties, the Mauser 98 safety is still my favorite on a bolt action or really any rifle out there. Right safe/bolt locked, middle the bolt opens for service or unloading/loading but blocks the sights so you don't confused and think it's ready to fire, then finally to the right is fire. Easy to learn, easy to understand on the clock and presumably under pressure.
Semi autos don't hold my interest so I can't say what I find super clever in one over another or how I would build one (depends on the intended use), but if I built a bolt action circa 1940 it'd look like a hybrid of a Type 99 and M1917. Cock on close variant of a Mauser action, tang extensions on the rear of the receiver and trigger guard on the stock, similar sights to those two guns (ideally mounted on the rear like an M1917), hinged floor plate with a release on the trigger guard, Mauser 98-style bayonet lug that doesn't impact the barrel in anyway with the bayonet on, Madsen-style rubber butt plate (always thought this was a nice touch), chrome bore, with the Mauser safety I like being the only thing I don't think you could really do. One bolt action I really want is a Mas36, I had the chance to buy one but don't want to stock any more ammo right now; it's a cool gun I'd like to study more as it was a bit different for it's time.